-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump DimensionalData dependency to 0.27 #390
Conversation
Pull Request Test Coverage Report for Build 8923198631Details
💛 - Coveralls |
you need to bump also the version of DD for docs. |
I don't understand why this failed, because the docs/Project.toml does not specify a version for any packages for good reason. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #390 +/- ##
==========================================
- Coverage 68.15% 67.34% -0.81%
==========================================
Files 12 12
Lines 1771 1770 -1
==========================================
- Hits 1207 1192 -15
- Misses 564 578 +14 ☔ View full report in Codecov by Sentry. |
I added a line to update the registry into the Documenter workflow and now the docs build successfully. I also updated the codecov action to 0.4 to hopefully fix the codecove issues on Ubuntu |
Merge? |
This replaces the deprecated DimensionalData functions key2dim and dim2key with their new versions.
The fix seemed to be very smooth but I am not sure whether this is breaking, because it might change the behaviour of the Ti and time axes.